Allow reading more than 32k Parquet row groups#10149
Open
etseidl wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
If this is needed sooner, I can revert the public changes and add an i32 accessor for use by the row numbering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
RowGroup.ordinalis absent #10129.Rationale for this change
The parquet crate will error if more than 32767 row groups are present in the file. This is a limit imposed on write when encryption is in use, but there is no other limit on the number of row groups beyond that imposed by the Thrift compact protocol.
What changes are included in this PR?
This changes the
ordinalfield of theRowGroupMetaDatafrom ani16toi32. This allows reading up to the maximum number of row groups allowed by Thrift. On write, theordinalon the RowGroup will not be written if more than 32k row groups are present.Are these changes tested?
Yes
Are there any user-facing changes?
Yes,
RowGroupMetaData::ordinalnow returnsOption<i32>andRowGroupMetaDataBuilder::set_ordinaltakesOption<i32>.