fix(brotli): Preserve ETag and Last-Modified headers in Brotli-compressed response - #12708
Closed
joshdcu wants to merge 1 commit into
Closed
fix(brotli): Preserve ETag and Last-Modified headers in Brotli-compressed response#12708joshdcu wants to merge 1 commit into
ETag and Last-Modified headers in Brotli-compressed response#12708joshdcu wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:XS
joshdcu
changed the title
ETag and Last-Modified headers in Brotli-compressed responseETag and Last-Modified headers in Brotli-compressed response
Contributor
|
Hi @yuweizzz, could you please confirm this change? |
Contributor
|
It is ok to preserve those headers, but for the etag header, if it exists, you need to transfer it to weak etag. and add a test case. |
Contributor
Hi @joshdcu, can you make further modifications? |
Author
|
Yes, will be working on it soon, thanks for the reminder! |
Baoyuantop
added
the
wait for update
Contributor
|
Hi @joshdcu, any update? |
Author
|
Sorry @Baoyuantop! I've been unavailable and haven't made a start yet. I would like to work on this eventually but I'm happy to let someone take this up if they want to. |
Contributor
|
Continue working on this change in #12853 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve
ETagandLast-Modifiedheaders in Brotli-compressed response.Which issue(s) this PR fixes:
Fixes #12707
Checklist