feat: add additional handling of prometheus-cache in ngx_tpl.lua (#1212703) - #12706
Closed
qihaiyan wants to merge 3 commits into
Closed
feat: add additional handling of prometheus-cache in ngx_tpl.lua (#1212703)#12706qihaiyan wants to merge 3 commits into
qihaiyan wants to merge 3 commits into
Conversation
added 2 commits
October 30, 2025 15:02
Baoyuantop
reviewed
Nov 21, 2025
| out="$(curl http://127.0.0.1:9091/apisix/prometheus/metrics)" | ||
| if ! echo "$out" | grep "apisix_stream_connection_total{route=\"1\"} 1" > /dev/null; then | ||
| echo "failed: prometheus can't work in stream subsystem" | ||
| echo "failed: prometheus can't work in both http & stream subsystem" |
Contributor
There was a problem hiding this comment.
Additional testing is needed; the existing tests cannot verify whether prometheus-cache is correctly generated when use_apisix_base=false.
Contributor
Author
There was a problem hiding this comment.
I didn't find out how to set use_apisix_base=false in ut environment, it's setted in env.lua:
local use_apisix_base = true
if not or_info:find("apisix-nginx-module", 1, true) then
use_apisix_base = false
end
Contributor
There was a problem hiding this comment.
I checked the existing tests and didn't find anything related to use_apisix_base=false, so I think this is acceptable. Let's see what other maintainers think.
Contributor
|
The issue it referenced is closed, so I'll close this PR for now. Please provide feedback and I'll reopen it if you have any questions. Thank you for your contribution @qihaiyan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Maybe it's better to set prometheus-cache together with prometheus-metrics in ngx_tpl.lua
Only when use_apisix_base is set to true, will the prometheus-cache take effect.
But in order to integrate with QAT, i used a custom built openresty instead of apisix-runtime, so use_apisix_base is not true, and prometheus-cache is not setted in nginx.conf even if prometheus plugin is enabled.
Which issue(s) this PR fixes:
Fixes #12703
Checklist