feat: As a user, I want to include the request body in the opa-input, so that I can reason about its contents by wistefan · Pull Request #11629 · apache/apisix

wistefan · 2024-10-08T14:06:48Z

Description

In order to make decisions based on the request body, the OPA-Plugin will also forward the body when configured to do so.

Fixes #11387

Checklist

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

wistefan · 2024-11-06T11:22:07Z

Is there anything I can do to get this PR forward?

github-actions · 2025-01-06T10:05:32Z

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

moonming · 2025-01-07T03:43:03Z

@wistefan Please synchronize the master code to trigger all CI

wistefan · 2025-01-07T07:12:58Z

@wistefan Please synchronize the master code to trigger all CI

@moonming Thank you for the review, I updated.

LuciaCabanillasRodriguez · 2025-03-24T14:24:21Z

Hello! If I want this new implementation with the request body, what should I do?

Baoyuantop · 2025-03-25T02:37:18Z

Hi @wistefan, please synchronize the latest master branch code to trigger the test.

Baoyuantop · 2025-04-01T06:45:59Z

Hi @wistefan, please fix failed ci

Baoyuantop · 2025-04-03T05:43:31Z

Hi @wistefan, do you have time to continue working on this PR?

wistefan · 2025-04-03T06:39:37Z

@Baoyuantop Yes, most likely beginning of next week

wistefan · 2025-04-17T10:59:55Z

@Baoyuantop Could you please appove the ci workflows?

Baoyuantop · 2025-04-23T02:07:30Z

@wistefan, please fix failed ci

LuciaCabanillasRodriguez · 2025-05-07T15:45:48Z

Hello! What is the status of this?

Baoyuantop · 2025-05-08T03:02:41Z

Need to fix the failed CI, waiting for a response from the author.

LuciaCabanillasRodriguez · 2025-05-27T19:43:06Z

Hello! Any news?

…of the service (apache#13513)

…13512)

…pache#13514)

…P workers when admin is disabled (apache#13515)

…e#13525)

… slash (apache#13519)

…malized key (apache#13517)

…hare a keepalive pool (apache#13516)

)

…ngs (apache#13547)

…and credentials (apache#13553)

…te (apache#13542)

…uce cardinality (apache#13202)

…pache#13422)

…r examples (apache#13543) * docs: fix mocking config note and invalid JSON in elasticsearch-logger examples - mocking: the docs say response_example and response_schema must not be configured together, but the schema uses anyOf (at least one) and the plugin prefers response_example when both are set. Correct the en/zh description accordingly. - elasticsearch-logger: the Admin API examples had a trailing comma after the only field ("index": "gateway",), making the JSON invalid for copy-paste. Remove it (en + zh, two places each). Signed-off-by: AlinsRan <alinsran@apache.org> * docs(mocking): clarify response_example/response_schema are not mutually exclusive The Required column said 'One of this or ...' / '二选一', implying the two fields are mutually exclusive, but the schema uses anyOf (at least one) and the plugin accepts both with response_example taking precedence. Align the column with that behavior. Signed-off-by: AlinsRan <alinsran@apache.org> --------- Signed-off-by: AlinsRan <alinsran@apache.org>

Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>

wistefan · 2026-06-16T07:49:12Z

@Baoyuantop @LuciaCabanillasRodriguez Hi, sorry, took far to long. But I think everything should be fixed now.

LuciaCabanillasRodriguez · 2026-07-14T11:16:51Z

Is there anything missing?

dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. doc Documentation things enhancement New feature or request labels Oct 8, 2024

wistefan mentioned this pull request Oct 11, 2024

feat: As a user, I want to include the request body in the opa-input, so that I can reason about its contents #11387

Open

github-actions Bot added the stale label Jan 6, 2025

moonming reviewed Jan 7, 2025

View reviewed changes

Comment thread apisix/plugins/opa/helper.lua Outdated

Comment thread apisix/plugins/opa/helper.lua Outdated

wistefan force-pushed the master branch from a0a86d3 to 60b1efe Compare January 15, 2025 08:45

github-actions Bot removed the stale label Jan 27, 2025

Baoyuantop reviewed Mar 25, 2025

View reviewed changes

Comment thread docs/en/latest/plugins/opa.md Outdated

Comment thread apisix/plugins/opa/helper.lua Outdated

Comment thread apisix/plugins/opa/helper.lua Outdated

Baoyuantop added this to ⚡️ Apache APISIX Roadmap Mar 28, 2025

Baoyuantop moved this to 👀 In review in ⚡️ Apache APISIX Roadmap Mar 28, 2025

Baoyuantop moved this from 👀 In review to 🏗 In progress in ⚡️ Apache APISIX Roadmap Mar 28, 2025

Baoyuantop moved this from 🏗 In progress to 👀 In review in ⚡️ Apache APISIX Roadmap Mar 28, 2025

wistefan force-pushed the master branch from 077b97d to 6d1d672 Compare March 31, 2025 07:57

wistefan requested a review from Baoyuantop March 31, 2025 08:18

Baoyuantop added the wait for update wait for the author's response in this issue/PR label Apr 29, 2025

nic-6443 and others added 27 commits June 16, 2026 09:35

fix(consul): one invalid node should not discard the remaining nodes …

c65bf44

…of the service (apache#13513)

fix(workflow): tolerate missing _workflow_cache in log phase (apache#…

5d7955a

…13512)

fix(plugin): ignore plugin_metadata of disabled or unknown plugins (a…

3ad1585

…pache#13514)

test(log-rotate): deflake the disable-via-hot-reload case (apache#13536)

31755b0

fix(xrpc): stream routes with xRPC protocols fail check_schema in HTT…

a2cba51

…P workers when admin is disabled (apache#13515)

fix(admin): encrypt_fields get double-encrypted on every PATCH (apach…

8523230

…e#13525)

fix(secret): aws secret manager fails when the secret name contains a…

18ff92a

… slash (apache#13519)

fix(core.request): set_header must update the cached headers with nor…

ae506b1

…malized key (apache#13517)

fix: redis connections with different database/credentials must not s…

19b1491

…hare a keepalive pool (apache#13516)

fix(graphql-proxy-cache): clear all Vary variants on PURGE (apache#13523

dc63528

)

fix: use description instead of title for field-level schema doc stri…

70e82a5

…ngs (apache#13547)

fix(limit-count): isolate redis-sentinel keepalive pools by database …

8891a9b

…and credentials (apache#13553)

fix: reduce vulnerable test dependencies (apache#13554)

a0e2a08

fix(brotli): don't log expected non-standard ETag at error level (apa…

0f031cf

…che#13545)

fix(ai-proxy): forward client method and query string for passthrough (…

4d9b68b

…apache#13546)

docs(ai-proxy): restore max_stream_duration_ms and max_response_bytes (…

be68533

…apache#13539)

fix(elasticsearch-logger): guard os.date against invalid index templa…

a3b093c

…te (apache#13542)

fix(nacos): declare nacos-stream shared dict in the stream subsystem (a…

d077887

…pache#13541)

fix(jwt-auth): reject malformed JWT signature instead of erroring (ap…

df7c5b7

…ache#13518)

feat(prometheus): support disabling labels via plugin metadata to red…

cf19b25

…uce cardinality (apache#13202)

fix(ci): verify LuaRocks tarball checksum before install (apache#13526)

83e2a56

fix(acl): correctly evaluate multi-match JSONPath labels (apache#13527)

eda61b3

docs(ai-proxy): document client request header forwarding behavior (a…

3c0886c

…pache#13422)

chore: release 3.17.0 (apache#13503)

53ac25c

Signed-off-by: Abhishek Choudhary <shreemaan.abhishek@gmail.com>

fix pr comments

a2a5ae6

Merge branch 'master' into master

8d16927

github-actions Bot added the user responded label Jun 16, 2026

Uh oh!

Conversation

wistefan commented Oct 8, 2024

Description

Checklist

Uh oh!

wistefan commented Nov 6, 2024

Uh oh!

github-actions Bot commented Jan 6, 2025

Uh oh!

Uh oh!

Uh oh!

moonming commented Jan 7, 2025

Uh oh!

wistefan commented Jan 7, 2025

Uh oh!

LuciaCabanillasRodriguez commented Mar 24, 2025

Uh oh!

Baoyuantop commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Baoyuantop commented Apr 1, 2025

Uh oh!

Baoyuantop commented Apr 3, 2025

Uh oh!

wistefan commented Apr 3, 2025

Uh oh!

wistefan commented Apr 17, 2025

Uh oh!

Baoyuantop commented Apr 23, 2025

Uh oh!

LuciaCabanillasRodriguez commented May 7, 2025

Uh oh!

Baoyuantop commented May 8, 2025

Uh oh!

LuciaCabanillasRodriguez commented May 27, 2025

Uh oh!

wistefan commented Jun 16, 2026

Uh oh!

LuciaCabanillasRodriguez commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants