feat: log why a resource is ignored when no IngressClass selects it - #2847
Open
janiussyafiq wants to merge 2 commits into
Open
feat: log why a resource is ignored when no IngressClass selects it#2847janiussyafiq wants to merge 2 commits into
janiussyafiq wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
A resource whose IngressClass does not select this controller is filtered out at the watch predicate, so it is dropped with no log, no event, and no status. Users cannot tell why their resource is never reconciled (see the
ingressClassNamepart of #2756).The shared predicate now logs why an object is ignored: at Info level when the resource is effectively orphaned (no
spec.ingressClassNameand no default IngressClass of this controller, or a referenced IngressClass that does not exist), and atV(1)when the IngressClass belongs to another controller, so multi-controller clusters are not spammed. Admission behavior is unchanged.Pre-submission checklist: