Skip to content

[Hotfix][AMS] Unify authentication handling for dashboard requests - #4312

Merged
zhoujinsong merged 1 commit into
apache:masterfrom
xxubai:remove-single-page-token
Aug 12, 2026
Merged

[Hotfix][AMS] Unify authentication handling for dashboard requests#4312
zhoujinsong merged 1 commit into
apache:masterfrom
xxubai:remove-single-page-token

Conversation

@xxubai

@xxubai xxubai commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Why are the changes needed?

Dashboard requests containing the legacy single-page token parameter follow a separate authentication path. This causes authentication behavior to differ between dashboard requests.

This change removes the legacy single-page token handling and ensures that all dashboard requests use the standard authentication flow.

Brief change log

  • Route all dashboard requests through the standard request authentication handler.
  • Remove the legacy single-page token generation and validation methods.
  • Remove the unused table-page token controller method.
  • Add tests covering catalog, terminal, and web-session authentication behavior.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

@github-actions github-actions Bot added the module:ams-server Ams server module label Aug 12, 2026

@zhoujinsong zhoujinsong left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the fix.

@zhoujinsong
zhoujinsong merged commit 1b094b4 into apache:master Aug 12, 2026
7 checks passed
xxubai added a commit that referenced this pull request Aug 12, 2026
…4312)

Remove single page token validation and related utility methods

(cherry picked from commit 1b094b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants