Skip to content

Triggerer: Strengthen Triggerer Metric Test Coverage #68545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SameerMesiah97 wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −4
Open

Triggerer: Strengthen Triggerer Metric Test Coverage #68545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions airflow-core/tests/unit/jobs/test_triggerer_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2851,15 +2851,26 @@ def test_handle_events_does_not_confirm_seq_when_persist_fails(jobless_superviso
def test_handle_events_emits_team_name(jobless_supervisor, team_name, expected_tags):
"""triggers.succeeded carries the triggerer's team_name (omitted when the triggerer has none)."""
jobless_supervisor.team_name = team_name
jobless_supervisor.events.append(TriggerEventEntry(1, TriggerEvent(True), 7))
jobless_supervisor.events.extend(
[
TriggerEventEntry(1, TriggerEvent(True), 7),
TriggerEventEntry(2, TriggerEvent(True), 8),
]
)

with (
mock.patch.object(TriggerRunnerSupervisor, "on_trigger_event", autospec=True),
mock.patch("airflow.jobs.triggerer_job_runner.stats.incr") as mock_incr,
):
jobless_supervisor.handle_events()

mock_incr.assert_called_once_with("triggers.succeeded", tags=expected_tags)
mock_incr.assert_has_calls(
[
mock.call("triggers.succeeded", tags=expected_tags),
mock.call("triggers.succeeded", tags=expected_tags),
]
)
assert mock_incr.call_count == 2


@pytest.mark.parametrize(
Expand All @@ -2872,15 +2883,26 @@ def test_handle_events_emits_team_name(jobless_supervisor, team_name, expected_t
def test_handle_failed_triggers_emits_team_name(jobless_supervisor, team_name, expected_tags):
"""triggers.failed carries the triggerer's team_name (omitted when the triggerer has none)."""
jobless_supervisor.team_name = team_name
jobless_supervisor.failed_triggers.append((1, None))
jobless_supervisor.failed_triggers.extend(
[
(1, Exception("failure one")),
(2, Exception("failure two")),
]
)

with (
mock.patch.object(TriggerRunnerSupervisor, "on_trigger_failure", autospec=True),
mock.patch("airflow.jobs.triggerer_job_runner.stats.incr") as mock_incr,
):
jobless_supervisor.handle_failed_triggers()

mock_incr.assert_called_once_with("triggers.failed", tags=expected_tags)
mock_incr.assert_has_calls(
[
mock.call("triggers.failed", tags=expected_tags),
mock.call("triggers.failed", tags=expected_tags),
]
)
assert mock_incr.call_count == 2


@pytest.mark.parametrize(
Expand Down
Loading