Skip to content

Use NOT EXISTS anti-join in Trigger.clean_unused and added skip locked #68244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntonioBergonzi wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −6
Open

Use NOT EXISTS anti-join in Trigger.clean_unused and added skip locked #68244

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
725b143
Use NOT EXISTS anti-join in Trigger.clean_unused instead of LEFT JOIN…
AntonioBergonzi Jun 8, 2026
05c885c
add FOR UPDATE SKIP LOCKED to Trigger.clean_unused to avoid deadlocks…
AntonioBergonzi Jun 12, 2026
2902fd6
Merge branch 'main' into ab/improve_slow_delete
hussein-awala Jun 12, 2026
ab47768
use with_row_locks helper and scope lock to trigger table
AntonioBergonzi Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions airflow-core/src/airflow/models/trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,12 @@ def clean_unused(cls, *, session: Session = NEW_SESSION) -> None:
)

# Get all triggers that have no task instances, assets, or callbacks depending on them and delete them
ids = (
select(cls.id)
.where(~cls.assets.any(), ~cls.callback.has())
.join(TaskInstance, cls.id == TaskInstance.trigger_id, isouter=True)
.group_by(cls.id)
.having(func.count(TaskInstance.trigger_id) == 0)
ids = select(cls.id).where(
~cls.assets.any(),
~cls.callback.has(),
~cls.task_instance.has(),
)
ids = with_row_locks(ids, session, of=cls, skip_locked=True, key_share=False)
if get_dialect_name(session) == "mysql":
# MySQL doesn't support DELETE with JOIN, so we need to do it in two steps
ids_list = list(session.scalars(ids).all())
Expand Down
Loading