-
Notifications
You must be signed in to change notification settings - Fork 17.3k
Fix N+1 queries in trigger asset event submission #65367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
henry3260
wants to merge
1
commit into
apache:main
Choose a base branch
from
henry3260:fix-n-1-query-in-trigger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,6 +50,7 @@ | |
| from airflow.utils.session import create_session | ||
| from airflow.utils.state import State | ||
|
|
||
| from tests_common.test_utils.asserts import count_queries | ||
| from tests_common.test_utils.config import conf_vars | ||
|
|
||
| if TYPE_CHECKING: | ||
|
|
@@ -234,6 +235,38 @@ def test_submit_event(mock_callback_handle_event, session, create_task_instance) | |
| mock_callback_handle_event.assert_called_once_with(event, session) | ||
|
|
||
|
|
||
| @patch("airflow.models.trigger.AssetManager.register_asset_change") | ||
| def test_submit_event_no_n_plus_one_for_assets(_, session): | ||
| """Ensure asset notifications do not trigger per-asset lazy-load queries.""" | ||
|
|
||
| def _create_trigger_with_assets(asset_count: int) -> int: | ||
| trigger = Trigger(classpath="airflow.triggers.testing.SuccessTrigger", kwargs={}) | ||
| session.add(trigger) | ||
| session.flush() | ||
|
|
||
| for i in range(asset_count): | ||
| asset = AssetModel(name=f"asset_{asset_count}_{i}") | ||
| asset.add_trigger(trigger, f"watcher_{i}") | ||
| session.add(asset) | ||
|
|
||
| session.commit() | ||
| session.expire_all() | ||
| return trigger.id | ||
|
|
||
| def _submit_event_query_count(trigger_id: int) -> int: | ||
| with count_queries(session=session) as query_result: | ||
| Trigger.submit_event(trigger_id, TriggerEvent("payload"), session=session) | ||
| return sum(query_result.values()) | ||
|
|
||
| small_query_count = _submit_event_query_count(_create_trigger_with_assets(1)) | ||
| larger_query_count = _submit_event_query_count(_create_trigger_with_assets(5)) | ||
|
|
||
| assert larger_query_count - small_query_count < 3, ( | ||
| f"Added 4 assets but query count increased by {larger_query_count - small_query_count} " | ||
| f"({small_query_count} -> {larger_query_count}), suggesting n+1 queries for trigger assets" | ||
| ) | ||
|
Comment on lines
+256
to
+267
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IIUC, we should parameterize the |
||
|
|
||
|
|
||
| def test_submit_failure(session, create_task_instance): | ||
| """ | ||
| Tests that failures submitted to a trigger fail their dependent | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we could collapse the these utility function as the test function itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, making it a nested function gives us limited gain here.