Skip to content

Add the option to select bundle version parameter on dag run trigger endpoint#61550

Open
itayweb wants to merge 64 commits into
apache:mainfrom
itayweb:feat-bundle-version-support-dagrun
Open

Add the option to select bundle version parameter on dag run trigger endpoint#61550
itayweb wants to merge 64 commits into
apache:mainfrom
itayweb:feat-bundle-version-support-dagrun

Conversation

@itayweb

@itayweb itayweb commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

A new feature in the dag run REST API, adding the option to add bundle version parameter to trigger specific version.
Wasn't sure how can I add to this a unit test due to need a git repo/s3 bucket, let me know if needed

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Cursor] following the guidelines

@boring-cyborg boring-cyborg Bot added area:API Airflow's REST/HTTP API area:DAG-processing labels Feb 6, 2026
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from 5b3753a to eea1f7d Compare February 7, 2026 14:58
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from eea1f7d to a862cd3 Compare February 7, 2026 18:22
@itayweb itayweb requested a review from potiuk as a code owner February 7, 2026 18:22
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch from a862cd3 to d47dcd4 Compare February 8, 2026 12:33
@itayweb itayweb force-pushed the feat-bundle-version-support-dagrun branch 2 times, most recently from 4aad19c to a87673a Compare February 8, 2026 19:51
pierrejeambrun
pierrejeambrun reviewed Feb 12, 2026
View reviewed changes

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me.

Can you add unit tests to verify that behavior when we actually pass a 'bundle_version'.

I'd love a second look from versioning experts.

ephraimbuddy
ephraimbuddy reviewed Feb 12, 2026
View reviewed changes
Comment thread airflow-core/src/airflow/serialization/definitions/dag.py Outdated
jason810496
jason810496 reviewed Feb 12, 2026
View reviewed changes

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

Please add the corresponding tests when you are convenient, thanks.

Comment thread airflow-core/src/airflow/api_fastapi/core_api/datamodels/dag_run.py
pierrejeambrun
pierrejeambrun reviewed Feb 17, 2026
View reviewed changes

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the requested unit tests please so we can merge this.

pierrejeambrun
pierrejeambrun reviewed Feb 17, 2026
View reviewed changes
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py Outdated
@itayweb

itayweb commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

I've added the unit test, let me know what do you think 😄 sorry for the delay

@github-actions

github-actions Bot commented Jun 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

uv.lock on main just moved via #68560 ("[main] Upgrade important CI environment"), commit 3ae8c6a and this PR currently conflicts.

Quickest fix:

git fetch upstream main && git rebase upstream/main
rm uv.lock && uv lock
git add uv.lock && git rebase --continue
git push --force-with-lease

Automated nudge — ignore if you're not ready to rebase. This comment is updated in place on future uv.lock bumps.

@guan404ming

guan404ming commented Jun 18, 2026

Copy link
Copy Markdown
Member

Overall looks great. @itayweb could you help resolve the conflict, thanks!

@itayweb

itayweb commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Overall looks great. @itayweb could you help resolve the conflict, thanks!

Done 👍

@vatsrahul1001

vatsrahul1001 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

@itayweb Can you look at failing test?

pierrejeambrun
pierrejeambrun reviewed Jun 25, 2026
View reviewed changes

@pierrejeambrun pierrejeambrun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your continuous effort on this. I believe we are getting close.

LGTM, just a few small adjusments

Comment thread airflow-core/src/airflow/api_fastapi/execution_api/versions/v2026_06_30.py Outdated
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py Outdated
Comment thread airflow-core/src/airflow/api_fastapi/execution_api/versions/__init__.py Outdated
@pierrejeambrun pierrejeambrun changed the title feat: adding the option to add bundle version parameter on dag run trigger endpoint Add the option to select bundle version parameter on dag run trigger endpoint Jun 25, 2026
@pierrejeambrun

pierrejeambrun commented Jun 25, 2026

Copy link
Copy Markdown
Member

Updated the description to follow our commit name policy. (cf Ash comment)

ephraimbuddy
ephraimbuddy reviewed Jun 27, 2026
View reviewed changes
Comment thread airflow-core/src/airflow/api_fastapi/core_api/routes/public/dag_run.py
ephraimbuddy
ephraimbuddy reviewed Jun 27, 2026
View reviewed changes
Comment thread airflow-core/src/airflow/serialization/definitions/dag.py
ephraimbuddy
ephraimbuddy reviewed Jun 27, 2026
View reviewed changes
Comment thread airflow-core/src/airflow/models/dag_version.py Outdated
@itayweb itayweb requested a review from ephraimbuddy June 28, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes
@rawwar rawwar Awaiting requested review from rawwar rawwar is a code owner
@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner
@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner
@choo121600 choo121600 Awaiting requested review from choo121600 choo121600 is a code owner
@ashb ashb Awaiting requested review from ashb ashb is a code owner
@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner
@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner
@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner
@guan404ming guan404ming Awaiting requested review from guan404ming guan404ming is a code owner
@vatsrahul1001 vatsrahul1001 Awaiting requested review from vatsrahul1001 vatsrahul1001 is a code owner
@potiuk potiuk Awaiting requested review from potiuk potiuk is a code owner
@dheerajturaga dheerajturaga Awaiting requested review from dheerajturaga dheerajturaga is a code owner
@kaxil kaxil Awaiting requested review from kaxil
@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh
@vincbeck vincbeck Awaiting requested review from vincbeck
@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner
@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner
@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:DAG-processing ready for maintainer review Set after triaging when all criteria pass.

Projects

None yet

Milestone

Airflow 3.3.1

Development

Successfully merging this pull request may close these issues.

Support bundle version param in trigger dag run endpoint

10 participants

@itayweb @pierrejeambrun @potiuk @eladkal @ashb @guan404ming @vatsrahul1001 @ephraimbuddy @jason810496