refactor(api): remove dead schema, fix two persistence defects, drop legacy fields#682
Merged
Merged
Conversation
…legacy fields Removes schema no code reads (process_workflow table+proto, resource.status/StatusEnum, orphan agent_deployment_info table, unused BatchQueueRepository, duplicate app_module_mapping entity mapping, dead credentials.CREDENTIAL_OWNER_TYPE column, and the grid-cert-legacy user_dn/generate_cert fields on ProcessModel/UserConfigurationDataModel with proto numbers reserved and Python stubs regenerated). Fixes two defects: parsing_template silently dropped its parser_connections DAG on save, and queue_status.RUNNING_JOBS was a bit(1) truncating the running-job count to 0/1 (now int). Adds UNIQUE constraints on tag(value) and resource_star(user_id, resource_id) with race-safe idempotent find-or-create. Entities and both V1 baselines stay in sync; verified with a clean build and a fresh-DB init of schema + seed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data-layer cleanup across the API. Removes schema that no code reads: the
process_workflowtable and proto message, theresource.statuscolumn andStatusEnum, the orphanagent_deployment_infotable, the unusedBatchQueueRepository, the duplicateapp_module_mappingentity mapping, the deadcredentials.CREDENTIAL_OWNER_TYPEcolumn, and the grid-cert-legacyuser_dn/generate_certfields onProcessModel/UserConfigurationDataModel(proto numbers reserved, Python stubs regenerated). Fixes two persistence defects:parsing_templatesilently dropped itsparser_connectionsDAG on save, andqueue_status.RUNNING_JOBSwas abit(1)truncating the running-job count to 0/1 (nowint). AddsUNIQUEconstraints ontag(value)andresource_star(user_id, resource_id)with race-safe, idempotent find-or-create. Entities and bothV1baselines stay in sync; verified with a clean build and a fresh-DB init of schema + seed.