Skip to content

review-kit 0.3.1: name maxVerifyPerJob again, document measured resume - #18

Merged
aoreshkov merged 1 commit into
mainfrom
fix/review-kit-0.3.1
Oct 27, 2026
Merged

aoreshkov merged 1 commit into
mainfrom
fix/review-kit-0.3.1

Conversation

@aoreshkov

Copy link
Copy Markdown
Owner

Summary

  • Regression fix: whenToUse names maxVerifyPerJob again. 0.3.0 dropped it while shortening the listing entry. In the seeded-defects real run, a prompt asking to "verify up to 5 findings per reviewer" launched without it; Claude found it in the script, stopped the run and started over. The entry is now 1,303 chars (still under the 1,400 the test allows), and a test keeps the argument named.
  • README, Continuing a run: the same-session resume is now measured on 2.1.311. Raising maxJobs from 2 to 4 brought the planner and both earlier reviewers back from the cache; the two new reviewers, all four verifiers (three of them re-checks with unchanged prompts) and the reporter ran.
  • README, Permissions: a resumeFromRunId relaunch goes by the run's script path, which Workflow(review-kit:review) does not match; in -p it was denied. Continuing with previous launches by name.

Release checks run on 0.3.0 (2.1.311)

  • Fresh session with 0.3.0 installed: the listing shows the whole entry, byte-identical to description + " - " + whenToUse.
  • Seeded-defects real run: 8/8 graders, 108 s, claude exit 0; a plain prompt launched the workflow (trigger check).
  • Resume measurement: as above.

Test plan

  • node --test (182 pass)
  • claude plugin validate --strict for ., ./review-kit, ./token-audit, ./token-meter
  • claude plugin test ./token-meter (40 pass)

After merge: tag review-kit-v0.3.1 (0.3.0 stays untagged, since it shipped the regression).

🤖 Generated with Claude Code

- whenToUse names maxVerifyPerJob again. 0.3.0 dropped it while
  shortening the listing entry, and a real run asked to verify up to
  5 findings per reviewer launched without it, then stopped and
  started over. A test keeps it named.
- README: the cache behaviour of a same-session resume is measured on
  2.1.311 (raising maxJobs from 2 to 4 brought the planner and both
  earlier reviewers back cached; every verifier and the reporter ran
  again).
- README: a resumeFromRunId relaunch goes by script path, which the
  Workflow(review-kit:review) rule does not approve; previous
  launches by name.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@aoreshkov
aoreshkov merged commit 22ca8d0 into main Oct 27, 2026
5 checks passed
@aoreshkov
aoreshkov deleted the fix/review-kit-0.3.1 branch October 27, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant