Repository navigation
GO-7578 Keep hidden internal properties out of type definitions - #3318
Open
requilence wants to merge 2 commits into
Open
requilence wants to merge 2 commits into
requilence wants to merge 2 commits into
Conversation
requilence
added a commit
that referenced
this pull request
Oct 11, 2026
The integration test's chat adapter predates ChatState, OpenSpaceChats and OpenObjectSearch on apicore.ChatSubscriptionService, so the package stopped building; it now reads the chat state as core/api does and refuses the two streams this fixture does not wire. The two Score subtests wait on the any-block bump in #3318 (GO-7578) and skip until it lands.
They waited on this bump to un-name hidden internal keys.
requilence
force-pushed
the
go-7578-internal-property-names
branch
from
October 11, 2026 12:38
dd54acd to
4e47b68
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the API v2 / MCP eval (MCP-08),
create_typewith a property named "Score" listed the internal fulltext_scoreon the type. Everycreate_objectafter that was refused, because_scoreis internal. That caused 8 of the 11 errors in the run.Two paths led there:
resolvePropertyInput, which ignores_and case, so "Score" matched_score.Change
keys.go: the step-4 match skips hidden internal keys._scorewritten exactly still resolves.idis kept, so its envelope refusal still fires.schema_write.go: in create_type and full-list update_type, aproperty_definitionsentry naming a hidden internal key is dropped and the response carries a warning. Entries the type already lists are kept, because the bundled template type liststemplateIsBundledand reading a type then sending it back must not remove it.typeops.go: theadd_propertyop refuses these keys instead of silently doing nothing.relationutils/recommended.godefaults).Dependency
anyproto/any-block#16 is merged and released as
v2.0.0-rc6. This PR bumps to it.Tests
internalprops_test.go. With the fix reverted, the "Score" cases fail../core/api/...and every package that imports anyblockjson pass, exceptTestV1ProtosMatchAnyBlockCanonicalSources, which fails the same way on develop already.