Support Apple specific messages 9, 10, 16 - #146
Open
thezealousfool wants to merge 1 commit into
Open
Conversation
Owner
|
Nice! Figuring this out can't have been trivial. Thanks for putting in the effort! It's unfortunate that they've chosen to reuse the AES-ECB cipher from the authentication phase. It's fine for a single message, but reuse is bad. See https://en.wikipedia.org/wiki/Block_cipher_mode_of_operation#ECB-weakness I wonder if there is a way to tell it to switch to a cipher that isn't completely broken.
I'm curious. What does the image look like? |
|
@thezealousfool: Interesting PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following messages:
This PR does not add full support of Apple's VNC client as the image does not look right but the keyboard and mouse events are transferred correctly so wanted to create a PR with the limited subset.