fix: use package version for serverless health metadata - #21
Closed
anwareset wants to merge 2 commits into
Closed
Conversation
Use the tracked package.json version when APP_VERSION is unavailable so Vercel deployments expose the release version without an environment variable. Preserve the Docker override and cover the serverless fallback with a health endpoint regression test. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keep the README environment-variable table focused on required user configuration while retaining the package metadata fallback in the application. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the tracked
package.json.versionas the/healthversion fallback whenAPP_VERSIONis unavailable. This allows Vercel deployments to report the release version without an injected environment variable while preserving the Docker build override.Verification
node --check src/server.jsgit diff --checkpnpm test(206/206passed)