W-092: build and verify release packages - #195
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
pnpm buildin the publish job after its frozen install.Release evidence
npm view @antst/dashi@0.1.0-alpha.18 dist.fileCount= 56; alpha.20 = 3.npm view @antst/dsh-file-uploads-none@0.1.0-alpha.18 dist.fileCount= 5; alpha.20 = 3.publish / Run pnpm gate:dockerinstalled all five workspace projects (+549 packages) on the publish runner, then its container-mounted gate built the workspace, leavingnode_modulesand compiledlib/output present for publish. W-072 removed that step from the publish job.packages/file-uploads-none/lib/index.js; afterpnpm build, it passes forlib/index.jsin file-uploads-none and dashi,cordis.patch.ymlin dashi-app, andbin/dashi.jsin dashi-launcher.Verification
pnpm gate: PASS — 26 files, 296 tests; DSH versions 233 packages at 0.1.5-rc.2; import lint 120 source files.