Skip to content

PQ19: Portuguese date names and Record.ToTable - #1

Merged
anton-belkin merged 1 commit into
anton-belkin:power-query-mfrom
Herr-Enklo:feat/pq19-portuguese-record
Oct 20, 2026
Merged

anton-belkin merged 1 commit into
anton-belkin:power-query-mfrom
Herr-Enklo:feat/pq19-portuguese-record

Conversation

@Herr-Enklo

Copy link
Copy Markdown

Adds full Portuguese weekday/month names and bounded standard date/time patterns for pt, pt-BR and pt-PT, plus Record.ToTable with ordered Name/Value rows. The handler checks the row limit, record shape and evaluator budget, and preserves held errors and existing lazy values without forcing them.

Based directly on power-query-m@20f2e36bc4c5dc01ee532aecad5ee86a022329c4. The change contains three library files, three test files including registration, and two documentation files. The 15 new test cases match this base's primitive table-type behavior. Dependencies, editor, permissions, worksheet-error projection and storage remain unchanged. Portuguese abbreviations/parsing limits, Any/Any metadata and general record-field laziness remain documented limits.

Validation on this exact branch:

  • 77 Query tests passed, including all six Portuguese and nine Record additions.
  • Full cargo xtask ci: all eight gates passed (fmt, clippy, test, assets, layers, wasm, parity, keytips); 1,704 tests passed, zero failed, one existing timing test ignored. Run offline with one Cargo build job.
  • cargo build --locked --offline -p gridcraft -p gridcraft-cli: compiled and linked both Windows programs successfully; neither program was launched for this port.
  • Two independent readers reviewed the actual eight-file tree; no concrete findings.

Earlier CI attempts exposed Windows checkout line endings in unchanged generated files and a compiler memory-allocation failure. Materializing the three generated files with LF produced their exact base Git blobs; the final passing run used the same contribution tree and no filtered tests. The existing WASM dead-code warning in Modified::At/Unknown remains.

Integration acceptance remains open beyond this bounded library coverage. Earlier native UI and Excel probes concerned the broader local integration build 283aaa45fb4fbabe067091e1974392f90cbc54ff, not this port. That Excel attempt returned 0x800A03EC from Workbooks.Open; its cause is unresolved and no Excel save/reopen roundtrip was established. That native UI evidence preserved seeded cache values and does not prove positive M evaluation. A separate .NET ODBC driver probe also did not validate this port and returned no rows. This port has not been run through native UI or Excel. Within this branch's Rust suite, the existing ODBC tests have conditional early-return paths, and the timeout/garbage HTTP tests have limited branch evidence. Passing those tests does not establish complete positive integration coverage.

Derived from the Herr-Enklo-authored PQ19 library change and adapted to this public interpreter. Existing authorship and licenses are preserved, including the foundations in storytold#1203 by Herr-Enklo and storytold#1532 by Anton Belkin. No GabLavareda source code or third-party workbook is included.

Add bounded Portuguese full-name formatting and ordered record-to-table
conversion with resource checks, 15 focused tests and documented limits.
@anton-belkin
anton-belkin merged commit e91897e into anton-belkin:power-query-m Oct 20, 2026
@anton-belkin

Copy link
Copy Markdown
Owner

Merged into power-query-m, thank you! Clean, well-bounded change, and all the new tests pass. The notes from docs/pq19-m-library.md now live in docs/gaps.md §12 and docs/architecture.md (the one-off file was dropped), and the date.rs conflict with the Italian names that landed meanwhile was resolved by keeping both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants