Repository navigation
PQ19: Portuguese date names and Record.ToTable - #1
Merged
anton-belkin merged 1 commit intoOct 20, 2026
Merged
anton-belkin merged 1 commit into
anton-belkin merged 1 commit into
Conversation
Add bounded Portuguese full-name formatting and ordered record-to-table conversion with resource checks, 15 focused tests and documented limits.
Owner
|
Merged into power-query-m, thank you! Clean, well-bounded change, and all the new tests pass. The notes from docs/pq19-m-library.md now live in docs/gaps.md §12 and docs/architecture.md (the one-off file was dropped), and the date.rs conflict with the Italian names that landed meanwhile was resolved by keeping both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds full Portuguese weekday/month names and bounded standard date/time patterns for
pt,pt-BRandpt-PT, plusRecord.ToTablewith orderedName/Valuerows. The handler checks the row limit, record shape and evaluator budget, and preserves held errors and existing lazy values without forcing them.Based directly on
power-query-m@20f2e36bc4c5dc01ee532aecad5ee86a022329c4. The change contains three library files, three test files including registration, and two documentation files. The 15 new test cases match this base's primitive table-type behavior. Dependencies, editor, permissions, worksheet-error projection and storage remain unchanged. Portuguese abbreviations/parsing limits,Any/Anymetadata and general record-field laziness remain documented limits.Validation on this exact branch:
cargo xtask ci: all eight gates passed (fmt, clippy, test, assets, layers, wasm, parity, keytips); 1,704 tests passed, zero failed, one existing timing test ignored. Run offline with one Cargo build job.cargo build --locked --offline -p gridcraft -p gridcraft-cli: compiled and linked both Windows programs successfully; neither program was launched for this port.Earlier CI attempts exposed Windows checkout line endings in unchanged generated files and a compiler memory-allocation failure. Materializing the three generated files with LF produced their exact base Git blobs; the final passing run used the same contribution tree and no filtered tests. The existing WASM dead-code warning in
Modified::At/Unknownremains.Integration acceptance remains open beyond this bounded library coverage. Earlier native UI and Excel probes concerned the broader local integration build
283aaa45fb4fbabe067091e1974392f90cbc54ff, not this port. That Excel attempt returned0x800A03ECfromWorkbooks.Open; its cause is unresolved and no Excel save/reopen roundtrip was established. That native UI evidence preserved seeded cache values and does not prove positive M evaluation. A separate .NET ODBC driver probe also did not validate this port and returned no rows. This port has not been run through native UI or Excel. Within this branch's Rust suite, the existing ODBC tests have conditional early-return paths, and the timeout/garbage HTTP tests have limited branch evidence. Passing those tests does not establish complete positive integration coverage.Derived from the Herr-Enklo-authored PQ19 library change and adapted to this public interpreter. Existing authorship and licenses are preserved, including the foundations in storytold#1203 by Herr-Enklo and storytold#1532 by Anton Belkin. No GabLavareda source code or third-party workbook is included.