Skip to content

Fix button replay fingerprint matching - #291

Open
0thernet wants to merge 2 commits into
antithesishq:mainfrom
0thernet:codex/button-fingerprint-matcher
Open

Fix button replay fingerprint matching#291
0thernet wants to merge 2 commits into
antithesishq:mainfrom
0thernet:codex/button-fingerprint-matcher

Conversation

@0thernet

@0thernet 0thernet commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • Match same-tag button fingerprints when both input types and nonempty text contents are present and equal.
  • Preserve the existing accessible-name and structural-path matcher fallbacks.
  • Add focused positive, negative, incomplete-identity, symmetry, and fallback-preservation tests.

Verification

  • cargo fmt --all -- --check
  • git diff --check
  • Independent static/adversarial review: approved

Executable Rust validation is delegated to upstream CI. This change is intentionally separate from #289.

@0thernet

0thernet commented Sep 2, 2026

Copy link
Copy Markdown
Author

GitHub Actions marked this fork PR as action_required before creating any jobs. Could a maintainer approve the workflow run and review this focused matcher fix? The branch is current with main, formatting and diff checks pass, and the change preserves the existing accessible-name and structural-path fallbacks.

@0thernet

0thernet commented Sep 7, 2026

Copy link
Copy Markdown
Author

Updated this branch with a normal merge of current upstream main a19243969153027e9b1dce5fe47ca98abbd4ec46. New head: d0b8d6be4897bd5ae682b939ec2525e9388477b6.

The feature delta remains exactly the original 80-line change in lib/bombadil-schema/src/browser.rs; upstream's deprecated optional double-click delay is preserved. Independent review found no issues. Formatting, diff checks, and all three bombadil-schema unit tests passed on the updated tree.

The new exact-head CI run is waiting for maintainer approval before any jobs can run. No force-push or history rewrite was used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant