ffmpeg: tolerate trailing CSV separator from side-data streams (iPhone .mov) - #31
ffmpeg: tolerate trailing CSV separator from side-data streams (iPhone .mov)#31siraustin wants to merge 1 commit into
Conversation
a52efbb to
4230d27
Compare
|
Updated after an external review pass: the tolerance is now exactly one optional trailing separator before whitespace (the shape FFmpeg's compact writer actually produces for an unselected nested One adjacent observation from the same review, deliberately left out of this PR to keep it minimal: |
h3_ffprobe_visual_size() runs
ffprobe ... -of csv=p=0:s=xand rejects any non-whitespace after the parsed WxH. For streams carrying side data — e.g. the display-matrix side data present in every iPhone-shot .mov — ffprobe's CSV writer appends a trailing field separator, so the output is3840x2160xand the probe fails with "FFprobe returned an invalid visual size" on files that are perfectly valid inputs.Repro:
ffprobe -v error -select_streams v:0 -show_entries stream=width,height -of csv=p=0:s=x IMG_xxxx.movon any iPhone clip →3840x2160x.Fix: tolerate stray separator characters (and whitespace) after the parsed size; anything else is still rejected, and the width/height sanity checks below are unchanged. Verified against the failing .mov (now parses 3840x2160) and a plain jpeg (unchanged, 1408x1408).
🤖 Generated with Claude Code