test: cover sendModLog channel selection (unset, non-text, fetch-failure branches)#21
Closed
dromzeh wants to merge 3 commits into
Closed
test: cover sendModLog channel selection (unset, non-text, fetch-failure branches)#21dromzeh wants to merge 3 commits into
dromzeh wants to merge 3 commits into
Conversation
Member
Author
|
abandoning — sendModLog's channel-selection can't be asserted in the full suite: an earlier suite caches mod-log.ts with the real env+logger, so the test's ~/env and ~/lib/logger mocks are bypassed and log.warn never hits the captured mock. not worth defeating bun's module cache for two logging branches. |
Member
Author
|
just like me fr!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
direct tests for the mod-log channel resolution warns, importing the real sendModLog via a post-mock dynamic import so the global mod-log stub in other suites does not clobber it