Skip to content

Checking the double call to the system function in method MIns… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fitorec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Checking the double call to the system function in method MIns… #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions minstall.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,8 @@ QString MInstall::getCmdOut(QString cmd)
if (fp == NULL) {
return QString (ret);
}
int i;
if (fgets(line, sizeof line, fp) != NULL) {
i = strlen(line);
int i = strlen(line);
line[--i] = '\0';
ret = line;
}
Expand Down Expand Up @@ -506,9 +505,10 @@ bool MInstall::makeLinuxPartition(QString dev, const char *type, bool bad, QStri
if (strncmp(type, "ext*", 4) == 0) {
// ext4 tuning
cmd = QString("/sbin/tune2fs -c0 -C0 -i1m %1").arg(dev);
}
if (system(cmd.toUtf8()) != 0) {
// error
if (system(cmd.toUtf8()) != 0) {
// error
return false;
}
}
}
return true;
Expand Down