Repository navigation
windows: caller env for MXC commands; SDK as optional peer - #822
Merged
Merged
Conversation
… peer spawnSandboxed() takes env, and MXC child environments merge ignoring case as srt-win's do. Installing the package no longer pulls in the SDK's native dependencies, so programs using the npm SDK must install it themselves. Co-authored-by: ig <ig@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets callers of
spawnSandboxed()set environment variables on MXC commands, and stops installing@microsoft/mxc-sdkand its native dependencies (koffi,node-pty) for every user of this package.spawnSandboxed()andMxcSandboxParamstakeenv, applied over every other layer.NODE_USE_ENV_PROXYis set when there is a proxy.import()no longer pull it in.Behaviour change: programs using
windows.backend: 'mxc'through the npm SDK must install it themselves or passwindowsMxcSdktoinitialize(). The README and the missing-SDK error say so. The Windows CI diagnostic step now installs the SDK itself.Test plan
bun teston the MXC,winsrtand config-validation files: 617 pass, 0 fail, 97 skipped (Windows only). New tests coverenvprecedence, one spelling per name, andNODE_USE_ENV_PROXY.tscis clean.koffiandnode-ptywere absent,buildMxcRequestmerged env as expected, andloadMxcSdkgave the new error.Generated by Claude Code