Repository navigation
windows: deny entries rank as on the other platforms - #686
Merged
ronleizrowice-ant merged 1 commit intoOct 12, 2026
Merged
ronleizrowice-ant merged 1 commit into
ronleizrowice-ant merged 1 commit into
Conversation
The ACEs set on an object come before the ones it inherits, so beneath a DENY on a directory an ALLOW set further down is the one that counts. That is the rank of allowRead over denyRead. rankWindowsFsAccess hands srt-win no such ALLOW for the two opposite ranks: a write grant at or beneath a write deny is a read grant, and a grant at or beneath a credentials.files entry is left out. A masked file is read-denied, as on macOS. A deny that one command brings is also stamped on the session's grants beneath it.
ronleizrowice-ant
deleted the
fix/windows-deny-entries-rank-as-on-the-other-platforms
branch
October 12, 2026 14:17
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows the filesystem lists and
credentials.filesbecome ACEs for the sandbox account.rankWindowsFsAccessranks them against each other beforesrt-winis called, as on the other platforms.denyWriteoverallowWrite: anallowWriteat or beneath adenyWritepath is granted read and execute only.credentials.filesover both allow lists: anallowReadorallowWriteat or beneath an entry is not granted. The trust bundle is the only exception.mode: "mask"file is read-denied, as on macOS: an ACL cannot redirect a read.customConfigis also stamped on the session's grants beneath it.An
allowReadbeneath adenyReadstays readable.Paths are compared as they resolve on disk, so links, junctions, 8.3 names and letter case make no difference. A UNC path is compared as spelled. No change to the helper.
What a configuration can notice
denyWritekeeps read and loses write.credentials.filesentry is gone.initialize()with the existingacl_stamp_failed, as amode: "deny"entry does.Testing
[winsrt Ln] ran: …. Their first run is this pull request's CI.Merge order
#683's ESLint rule names the one
fs.realpathSync.nativecall here. Whichever lands second settles it.