Skip to content

fix: align model capabilities schema with OpenCode v2 root properties…#26

Open
ganimalqudhaifi wants to merge 2 commits into
anthonyhaussman:mainfrom
ganimalqudhaifi:fix/align-model-capabilities
Open

fix: align model capabilities schema with OpenCode v2 root properties…#26
ganimalqudhaifi wants to merge 2 commits into
anthonyhaussman:mainfrom
ganimalqudhaifi:fix/align-model-capabilities

Conversation

@ganimalqudhaifi

@ganimalqudhaifi ganimalqudhaifi commented Jul 23, 2026

Copy link
Copy Markdown

Based on the dev branch, added root properties (reasoning, attachment, tool_call, modalities) for OpenCode v2 compatibility.

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility with OpenCode v2 model caching.
    • Preserved model-specific settings, including reasoning, attachments, tool calls, temperature, modalities, and input/output capabilities.
    • Prevented model configuration changes from unintentionally affecting shared defaults.

@ganimalqudhaifi

Copy link
Copy Markdown
Author

you can check this different with 'opencode models google-agy --verbose'

Repository owner deleted a comment from coderabbitai Bot Jul 24, 2026
@anthonyhaussman
anthonyhaussman force-pushed the fix/align-model-capabilities branch from 0a20c9f to 123b483 Compare July 24, 2026 05:06
Repository owner deleted a comment from coderabbitai Bot Jul 24, 2026
Comment thread src/plugin.ts
Comment on lines +340 to +355
temperature: (existing as any).temperature ?? (modelDetails as any).temperature,
modalities: {
...((existing as any).modalities || {}),
...((modelDetails as any).modalities || {})
},
capabilities: {
...(existing.capabilities || {}),
...(modelDetails.capabilities || {}),
input: {
...(existing.capabilities?.input || {}),
...(modelDetails.capabilities?.input || {})
},
output: {
...(existing.capabilities?.output || {}),
...(modelDetails.capabilities?.output || {})
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The static defaults (modelDetails) are being spread after the custom configurations (existing) for modalities and capabilities. This causes the static defaults to silently overwrite any custom model configurations provided by the user/provider.

Suggested change
temperature: (existing as any).temperature ?? (modelDetails as any).temperature,
modalities: {
...((existing as any).modalities || {}),
...((modelDetails as any).modalities || {})
},
capabilities: {
...(existing.capabilities || {}),
...(modelDetails.capabilities || {}),
input: {
...(existing.capabilities?.input || {}),
...(modelDetails.capabilities?.input || {})
},
output: {
...(existing.capabilities?.output || {}),
...(modelDetails.capabilities?.output || {})
}
modalities: {
...((modelDetails as any).modalities || {}),
...((existing as any).modalities || {})
},
capabilities: {
...(modelDetails.capabilities || {}),
...(existing.capabilities || {}),
input: {
...(modelDetails.capabilities?.input || {}),
...(existing.capabilities?.input || {})
},
output: {
...(modelDetails.capabilities?.output || {}),
...(existing.capabilities?.output || {})
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants