fix(ci): restore gates and artifacts dropped in #2979 - #3033
Conversation
Bring back Node 22/24/26 coverage, skillmark/actionlint hooks, named VSIX/npm-tarball uploads, SHA-pinned artifact actions, and a pnpm-based package script while keeping the consolidated test job.
There was a problem hiding this comment.
Pull request overview
Restores CI quality gates and artifact publishing that were removed or regressed in #2979, aligning the next workflow back with expected Node compatibility, linting coverage, and artifact outputs.
Changes:
- Restores Node test matrix coverage (22/24/26) and improves job/artifact naming to include Node version.
- Re-enables
actionlintandskillmarkinprek.toml, including scopingskillmarkto repo-owned skill trees. - Pins artifact-related actions to commit SHAs and restores stable artifact uploads (vsix/plugin/mcp-server/language-server/npm tarballs), plus fixes the
packagescript to usepnpm run build.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
prek.toml |
Re-enables and configures skillmark + actionlint prek hooks. |
package.json |
Fixes package script to build via pnpm instead of npm. |
CLAUDE.md |
Updates CI/CD documentation to reflect the next workflow behavior. |
AGENTS.md |
Updates contributor prerequisites guidance for CI tooling. |
.skillmark.toml |
Expands excludes and documents WDIO .wdio-vscode handling. |
.github/workflows/next.yml |
Restores Node matrix (22/24/26), pins actions, and restores artifact gating/naming. |
.github/actionlint.yaml |
Points actionlint ignores at next.yml (and keeps parallel-step ignores). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe pull request enables Skillmark and Actionlint validation, expands repository exclusions and setup guidance, updates the CI matrix to Node 22/24/26 on Linux, pins workflow actions, and refines package artifact generation and documentation. ChangesCI validation and packaging
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 97-104: Update the “tools beyond the workspace node_modules
install” section in AGENTS.md to list only uv as an external prerequisite. Keep
the existing pnpm exec prek availability guidance, but remove prek from the
external-install requirement and clarify that contributors must install uv
locally before running pnpm run ci or pnpm run lint.
In `@prek.toml`:
- Around line 22-30: Update the skillmark hook configuration in prek.toml to
pass the CLI --exclude option for .wdio-vscode, while retaining the existing
.skillmark.toml config and skill directory arguments. Ensure auto-discovered
skills under .wdio-vscode are excluded from the lint invocation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8870dd56-1052-4f22-95c8-7a3de4d66e0f
📒 Files selected for processing (7)
.github/actionlint.yaml.github/workflows/next.yml.skillmark.tomlAGENTS.mdCLAUDE.mdpackage.jsonprek.toml
Clarify docs, add skillmark --exclude, and skip WDIO UI on Node 26 where Chromedriver session create fails (tracked in ansible#3035).
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-project-automation
Bot
moved this from In Progress
to Review
in 🧰 devtools project board
Matrix jobs report as test-linux-nodeNN; add a thin aggregator so the branch ruleset required context `test-linux` can complete.
|
The Pushed an aggregator job named `test-linux` that succeeds only when all matrix cells succeed. |
github-project-automation
Bot
moved this from Review
to Done
in 🧰 devtools project board
Summary
enginesstill allows>=22.18.0; chore: simplify gha workflow #2979 collapsed to 24-only without a compatibility reason)prek.toml(actionlint path updated tonext.yml; skillmark scoped to.agents/skills+skillswith--exclude .wdio-vscode/**)ansible/actions/upload-artifact@mainvsixartifact name + npm tarball uploads (once on linux/node 24)packagescript to usepnpm run buildinstead ofnpm run buildmacos×ubuntu-latestduplicate matrix cells — tracked in ci: restore real macOS coverage for next workflow #3034UND_ERR_INVALID_ARG) — tracked in ci: restore WDIO UI coverage on Node 26 #3035; lint/unit/integration/package still run on 26Keeps the monolithic
testjob from #2979 (job count intentionally unchanged).Addresses post-merge review on #2979 / AAP-81317 fallout.
Test plan
pnpm run cilocally (pre-push)pnpm exec prek run skillmark actionlint -atest-linux-node22,test-linux-node24,test-linux-node26test-linux-node26green with UI skippedvsix,plugin,mcp-server,language-server,npm-tarballstest-linuxcheck while retaining version-specific matrix job names.packagescript topnpm run build, and skips WDIO UI tests on Node 26.Related:
#2979