Fix WN22-AU-000330: correct when condition to check for failure auditing - #17
Open
andriy-bulynko wants to merge 1 commit into
Open
Fix WN22-AU-000330: correct when condition to check for failure auditing#17andriy-bulynko wants to merge 1 commit into
andriy-bulynko wants to merge 1 commit into
Conversation
Signed-off-by: Andriy Bulynko <andriy.bulynko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure that you have understood contributing guide
Ensure all commits are signed-by and gpg signed
Overall Review of Changes:
Fix MEDIUM | WN22-AU-000330 | PATCH | Windows Server 2022 must be configured to audit System | IPsec Driver failures.
The when condition was checking for 'Success' not in the audit output, but the task configures /failure:enable. This caused failure auditing to be skipped incorrectly. The condition should check for 'Failure' not in to match the audit type being configured.
Issue Fixes:
Closes #16
Enhancements:
N/A
How has this been tested?:
Tested against Windows Server 2022 using the Microsoft Windows Server 2022 STIG SCAP Benchmark. After applying the fix, the corresponding rule passes audit.