New module for hashicorp packer - #12492
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Hello again, friends @russoz @felixfontein I'm trying once again to improve our open-source community. Recently at work, I came across the Packer utility and decided to use a convenient module instead of cmd and shell. |
|
Hello again, I would be happy if you have the chance to take a look at and respond to my PR. |
russoz
left a comment
There was a problem hiding this comment.
Thanks for another contribution. There's quite a number of adjustments to make and I have not marked them all, many of them are repeated throughout the code.
It might be that you are using AI to help you, which is OK, but please make sure to abide by the Ansible Community Policy for AI-Assisted Contributions. Thanks!
felixfontein
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
|
Dear friends @russoz @felixfontein , I apologize for tagging you. |
russoz
left a comment
There was a problem hiding this comment.
Thanks for your continued work on this. Please see some additional comments.
This comment was marked as resolved.
This comment was marked as resolved.
|
@russoz thx you for your help and for finding my issues in the code. All tests have been passed and fixed. |
|
Every time you force-push the commit, the comments we made before become invalid and we have to circle back to all of them to validate the changes. Please don't. |
Oh no, I'm so sorry, I didn't know. I intentionally cleaned up the commit history because in the previous module I had many commits for each of your comments, and at the end you asked me to squash them all into a single commit for merging branches. |
|
Ideally, when we have many small commits, we should squash them before pushing. Or a simpler way to put it: when squashing, do not include the commits that were pushed before. |
russoz
left a comment
There was a problem hiding this comment.
Another batch of comments. We're getting there. Thanks for you continued work on this.
russoz
left a comment
There was a problem hiding this comment.
Another round of comments.
|
@russoz Hi again, please take a look at my corrections. |
russoz
left a comment
There was a problem hiding this comment.
Thanks for the adjustments. Another round, many of them are minor nits now. We are getting there!
SUMMARY
New module
packerto manage HashiCorp Packer builds. This module supports:ISSUE TYPE
COMPONENT NAME
packer
ADDITIONAL INFORMATION
This module provides Ansible users with native integration for HashiCorp Packer, allowing them to build, validate, and manage Packer templates directly from playbooks.