refactor(tui): extract shared session rendering primitives - #48393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First small code increment toward shared, nested session rendering.
render-context.tsx.message-parts.tsx.InlineToolRowexport.This is a mechanical extraction. Grouping, scrolling, navigation, disclosure defaults and presentation remain unchanged. Larger tool-specific and group renderer extractions can follow in separate increments. The planning document and diagnostic scripts remain local.
Verification
bun typecheckinpackages/tui: passed--dev: replayed the baseline fixture and inspected busy exploration plus completed thought/read/text at 112x34 and 80x24. Layouts match visually; real durations and animation frames vary.Baseline:
8f4d7066473ea07d26c5dfc35e46cd9a94e3e292. Replaces the closed documentation-only PR #48392 with an actual code increment.