fix(codemode): coerce enumeration sources like JS ToObject - #48257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Object.keys/values/entries/hasOwn/assign, object spread, andfor...inrejected anything that was not a plain object or array. JS applies ToObject first, so they should behave like this:One ToObject step for seven sites
The un-awaited-Promise and tool-reference hints move into the shared step, so they fire uniformly —
for (k in tools.x.y())gets the await hint too.Deviations kept
Object.assign("a", …)StringTypeErrorObject.keys(promise)[]awaitTests
test/object-coercion-test262.test.tsports 23 Test262 files:Object/keys×5,entries×3,values×3,hasOwn×3,assign×9. Only the boxed-primitive files are omitted;Override.jsasserts throughObject.keysinstead ofgetOwnPropertyNames.bun typecheckbun test— 1170 pass