fix(cli): print explicitly requested --help to stdout - #48167
Open
giner wants to merge 1 commit into
Open
Conversation
Explicit help is normal output; only help shown on a usage error belongs on stderr. Writing it to stdout keeps it pipeable and greppable, and separates it from error output.
github-actions
Bot
added
needs:issue
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit help is normal output, only help shown on a usage error belongs on stderr. Writing it to stdout keeps it pipeable and greppable, and separates it from error output.
Issue for this PR
Fixes #48173
Type of change
What does this PR do?
Explicitly requested help (
--help/-h) is normal output, not a diagnostic, but it was written to stderr, indistinguishable from error output and not pipeable. This PR routes user-requested help to stdout; help shown on a usage error still goes to stderr.How did you verify your code works?
Ran tests locally
Checklist