fix(app): register open project and new worktree shortcuts in new layout#37830
Open
ProdigyRahul wants to merge 5 commits into
Open
fix(app): register open project and new worktree shortcuts in new layout#37830ProdigyRahul wants to merge 5 commits into
ProdigyRahul wants to merge 5 commits into
Conversation
ProdigyRahul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37829
Type of change
What does this PR do?
registers two shortcuts that only existed in the legacy layout, so they work again in the new layout.
cmd+o (project.open) opens the folder picker. it was registered only in the legacy layout, so the new layout had nothing to trigger. this adds it to the new layout titlebar next to the other global commands.
cmd+shift+w (workspace.new) starts a new worktree. the new session composer already defers worktree creation to submit, so this registers the shortcut on the draft page to set the workspace selection to create and refocus the input. it is gated on the workspace bar being available (git project), matching the legacy command.
How did you verify your code works?
ran the desktop app on the new layout, pressed cmd+o to confirm the native folder picker opens and the chosen folder starts a new session, and pressed cmd+shift+w on a git project draft to confirm the workspace selector switches to new worktree. typecheck passes on app.
Screenshots / recordings
Before:
After:
Checklist