feat(core): publish pending MCP status during connect#37605
Open
rekram1-node wants to merge 1 commit into
Open
feat(core): publish pending MCP status during connect#37605rekram1-node wants to merge 1 commit into
rekram1-node wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #37308, addressing known trade-off #1 (no pending status during connect).
startServernow setsstatus: "pending"and publishesStatusChangedbefore opening the connection, soservers()and event subscribers see an accurate status for the duration of the handshake instead of the stale prior status (disabled/failed) for up to the startup timeout.Placing this at the top of
startServercovers all four entry points uniformly:pending, now also announced)add()(new entries are announced at admission rather than only when the handshake settles)connect()(previously showed the stale prior status mid-handshake)Cost: transitions now emit two
StatusChangedevents (pending, then the outcome) instead of one.pendingis an existing status the app already maps.No mid-handshake observability in tests: asserting the transient
pendingstate deterministically needs a fixture server with controllable connect latency (same limitation as trade-off #6). Existing suite passes (18/18), typecheck clean.