Skip to content

fix(core): remove session import cycle#37596

Merged
opencode-agent[bot] merged 1 commit into
v2from
session-import-cycle
Jul 18, 2026
Merged

fix(core): remove session import cycle#37596
opencode-agent[bot] merged 1 commit into
v2from
session-import-cycle

Conversation

@opencode-agent

Copy link
Copy Markdown
Contributor

Summary

  • move Session.NotFoundError to the existing session error leaf module
  • make Permission depend on session schema/error modules instead of the full Session module
  • revert lazy LayerNode dependencies now that the runtime import cycle is removed

Verification

  • bun typecheck in packages/core
  • bun test test/effect/layer-node/layer-node.test.ts test/effect/layer-node/layer-node-types.test.ts (14 pass)
  • verified there is no runtime import path from session/execution.ts back to session.ts

Requested by: @jlongster (James Long via Slack)

@opencode-agent
opencode-agent Bot merged commit 529d55b into v2 Jul 18, 2026
10 checks passed
@opencode-agent
opencode-agent Bot deleted the session-import-cycle branch July 18, 2026 13:24
github-actions Bot pushed a commit to ReStranger/opencode that referenced this pull request Jul 18, 2026
* upstream/v2:
  feat(core): publish pending MCP status during connect (anomalyco#37605)
  feat(codemode): native coercion parity in interpreter (anomalyco#37608)
  test(core): stabilize shell progress test (anomalyco#37643)
  fix(ai): parse compatible reasoning deltas (anomalyco#37558)
  fix(core): remove session import cycle (anomalyco#37596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant