fix(web): New Session button on fresh start / no-opened-projects#37591
Closed
ndj888 wants to merge 1 commit into
Closed
fix(web): New Session button on fresh start / no-opened-projects#37591ndj888 wants to merge 1 commit into
ndj888 wants to merge 1 commit into
Conversation
…ects On a fresh `opencode web` start, the "New Session" button in the titlebar silently does nothing and the home page hides its "New Session" buttons. This happens because: 1. `newSessionProject()` in home.tsx relies solely on `projects()` (persisted opened projects), which is empty. 2. `openNewTab()` in titlebar.tsx has a 5-case fallback chain that all fail when no projects are persisted: home selection is empty, layout.projects.list() is empty, and global.ensureServerCtx(conn).projects.list() returns only persisted projects — never server-registered ones. Fix: - home.tsx: add sync data fallback to `newSessionProject` (registered projects from the server API) - titlebar.tsx: add a final fallback that reads server-registered projects from sync.data.project when all other cases fail
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window. Feel free to open a new pull request that follows our guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When you run
opencode webfor the first time (or with no persisted project state), the Web UI becomes unusable because:Titlebar "New Session" button (+): Clicking does nothing — the handler (
openNewTab) falls through 5 cases and silently returns when none find a project directory.Home page "New Session" buttons: Hidden entirely because
newSessionProject()returnsundefinedwhenprojects()(persisted opened-projects list) is empty.The issue persists even though the server does have registered projects (returned by
GET /project).Root Cause
The web UI stores opened projects in
localStorage(opencode.global.dat:server→projects.<scope>). On fresh start:global.servers.list()may be populated (viaentry.tsxservers={[server]}), butglobal.ensureServerCtx(conn).projects.list()reads only persisted projects — which are empty on first launch.The server-registered projects (from
sync.data.project, populated by the/projectAPI) are never consulted as a fallback for session creation.Reproduce
Fix
Two targeted changes:
packages/app/src/pages/home.tsx—newSessionProject():?? focusedSync().data.project[0]fallback.packages/app/src/components/titlebar.tsx—openNewTab():global.ensureServerCtx(conn).sync.data.project[0].Verification
Manually tested on
opencode web --port 19820with cleared localStorage:/new-session?draftId=...