refactor(desktop): unify sidecar controller interface#37589
Open
Hona wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a shared sidecar abstraction in the desktop main process by defining a single SidecarInstance contract and providing a reusable BaseSidecarController implementation to standardize lifecycle/status handling across sidecar kinds (local vs WSL).
Changes:
- Added
SidecarInstance/SidecarStatus/SidecarKindtypes plus aBaseSidecarControllerimplementation. - Added unit tests validating lifecycle state transitions and startup-failure handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/desktop/src/main/sidecar/types.ts | Adds unified sidecar interface/types and a base controller implementation with status transitions. |
| packages/desktop/src/main/sidecar/controller.test.ts | Adds tests for controller state transitions and failure behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+28
to
+29
| expect(controller.getUrl()).rejects.toThrow("Failed to start server") | ||
| expect(controller.status).toBe("failed") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Establishes a unified \SidecarInstance\ interface and \BaseSidecarController\ implementation for desktop sidecars (local vs WSL).
Details
eady, \ ailed, \stopped).