test(cli): lock managed reconnect ensure-on-first-failure#37570
Open
armancharan wants to merge 2 commits into
Open
test(cli): lock managed reconnect ensure-on-first-failure#37570armancharan wants to merge 2 commits into
armancharan wants to merge 2 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This was referenced Jul 17, 2026
armancharan
commented
Jul 17, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36581
#36581
Parent epic: #36441
✧ raised · ○ in review · ● approved · ✓ merged
#36441 epic: scope streams + bound payloads
Merge in order:
v2
└ ○ #37486 location interest
└ ○ #37487 session interest + fan-out bench
└ ○ #37585 stream ownership / diagnostics
└ ○ #37586 reconnect herd
Siblings under the epic (not git parents of the stack tip):
└ ○ #37559 session blobs + payloadHash
└ ○ #37570 ensure-on-first-failure ← this PR → feeds #37586
Builds toward #36285.
Type of change
What does this PR do?
The ensure-on-first-failure reconnect policy already landed with the managed service lifecycle work (
ServerConnectionreconnect →Service.ensurewithversion: undefined; TUI calls it on every stream drop).This adds the missing regression coverage from #36581:
onStart("missing"))Also exports
ServerConnection.managedReconnectso that policy is testable without going through the full resolve path.How did you verify your code works?
bun test test/server-connection.test.ts --timeout 30000bun run typecheckinpackages/cliAcceptance
managed reconnect ensures the service on the first failuremanaged reconnect reuses a healthy service from another versionScreenshots / recordings
n/a
Checklist