fix(tui): preserve contrast for transparent themes#37264
Open
vaibhavshn wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Related PR FoundPR #36239 - This is the original PR that the current PR (37264) was ported from. According to the PR description, #36239 was targeting the dev branch, and #37264 re-applies the same fix. This appears to be an intentional re-application rather than a duplicate issue, as the PR explicitly mentions it was "ported over" from #36239. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #30056.
Ported over from #36239 which was targeting dev branch.
Type of change
What does this PR do?
Badge text becomes invisible if your background is transparent. This fixes that by checking the background color and setting the text color accordingly in two places: file badge when a file is tagged, and another in the diff viewer.
How did you verify your code works?
Ran this with same theme and terminal, and you can see the screenshots below for before and after.
In my case, I ran it with system theme in Ghostty. You will see this with any theme in Ghostty.
Screenshots / recordings
Badge
Before:
After:
Diff Viewer
Before:
After:
Checklist
If you do not follow this template your PR will be automatically rejected.