fix(opencode): support mise-managed upgrades#36573
Open
shanebishop1 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36572
Type of change
What does this PR do?
OpenCode currently detects updates for mise-managed installations, but cannot apply them because mise is treated as an unknown installation method.
This PR detects binaries installed through mise and asks mise which config selected the running version. It updates that exact config while preserving its pinned or fuzzy version format. If the source cannot be identified unambiguously, the upgrade fails without modifying or creating a config file.
The existing installation detection sequence is intentionally preserved. On startup, the backend checks for updates while the TUI separately connects to the event stream and registers the listener that opens the update dialog. Returning
miseimmediately made the check complete before that listener was ready, so the one-shot update event was lost and no popup appeared. Keeping the existing sequence preserves current startup ordering; adding an explicit TUI readiness handshake would be the cleaner long-term fix, but felt out of scope here.Ambiguous sources fail rather than falling back to
mise install, since installing without activating the target would misleadingly report a successful upgrade.How did you verify your code works?
Added focused tests and manually verified the full update popup flow from a mise-managed
1.17.14installation to1.17.18.Screenshots / recordings
N/A
Checklist