fix(core): preserve sqlite error details#36570
Open
bvolpato wants to merge 3 commits into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This was referenced Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36578
Related context: #33356.
Type of change
What does this PR do?
SQLite failures were reduced to
Failed to execute statement, which hid actionable causes. This preserves sanitized SQLite result details through Drizzle and session error handling, soSQLITE_FULLreportsdatabase or disk is fullwithout exposing query parameters or native values.It also includes the Node 24
EventEmitter.emitcompatibility fix required for the currentdevbranch and its locked typings to pass the repository typecheck.How did you verify your code works?
bun test test/database-sqlite.test.ts --timeout 30000 --only-failuresinpackages/corebun test test/session/message-v2.test.ts test/project/project.test.ts --timeout 30000 --only-failuresinpackages/opencodebun typecheckat the repository rootScreenshots / recordings
Not applicable.
Checklist