feat(plugin): flat tool draft with namespace#36561
Open
rekram1-node wants to merge 1 commit into
Open
Conversation
rekram1-node
force-pushed
the
tool-flat-draft
branch
4 times, most recently
from
3025604 to
203266a
Compare
rekram1-node
force-pushed
the
tool-flat-draft
branch
2 times, most recently
from
1b0afd8 to
370bfbd
Compare
rekram1-node
changed the title
rekram1-node
force-pushed
the
tool-flat-draft
branch
3 times, most recently
from
fa95bef to
abb860a
Compare
Effect draft.add accepts flat tool objects matching Promise ergonomics. Migrate the tool grouping concept fully to namespace: rename MCP's group helper/registration to namespace and thread namespace through the flat Effect and Promise draft declarations.
rekram1-node
force-pushed
the
tool-flat-draft
branch
from
abb860a to
6714f74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
draft.addaccepts flat tool objects (same ergonomics as Promise)group→namespacepinned(rejected whencodemode: false)Stacked on #36560. Part of #36196
Stack
deferred→codemodenamespace/pinneddraft.namespace.add, dotted paths)Test plan
bun typecheckinpackages/pluginandpackages/corebun test test/plugin.test.ts test/session-runner-tool-registry.test.ts test/mcp.test.tsinpackages/core