fix(opencode): add SIGKILL fallback to Process.stop()#36559
Open
beowulfof wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36558
Type of change
What does this PR do?
Process.stop()inpackages/opencode/src/util/process.tsonly sentproc.kill()(SIGTERM) with no timeout or SIGKILL fallback. When an LSP server ignores SIGTERM (e.g. rust-analyzer, clangd), the process remains as a zombie — no escalation to SIGKILL ever happens.The
aborthandler inProcess.spawn()(same file, line 74) already had the correct pattern: SIGTERM → 5s timeout → SIGKILL.stop()was simply missing this escalation chain.The fix wraps the existing
proc.kill("SIGTERM")with a race between the process exit event and a 5-second timer that escalates to SIGKILL. The SDK copy (packages/sdk/js/src/process.ts) is updated to stay in sync.How did you verify your code works?
bun typecheck: 30/30 tasks, all passbun test test/util/process.test.ts: 10/10 tests passScreenshots / recordings
N/A
Checklist