feat: Add title attribute to script tag for better accessibility - #25
Open
enrique-ramirez wants to merge 2 commits into
Open
feat: Add title attribute to script tag for better accessibility#25enrique-ramirez wants to merge 2 commits into
enrique-ramirez wants to merge 2 commits into
Conversation
enrique-ramirez
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For accessibility reasons, an iframe should have a title or an aria-label attribute. This PR adds a
titleattribute.We use announcekit on our product and right now the accessibility standards requested by our enterprise customers are not being met. The fix is simple, though, and this would benefit us immensely.
Hope this can be reviewed and merged as is, but let me know if there's anything I might need to include here.
@namirali @mcucen