Open 0.2.0 development - #7
Merged
Merged
Conversation
0.1.0 is released, so the working tree should stop building artifacts that carry a version already on Maven Central. Five places, because the version is genuinely two numbers that have to agree. Gradle's default goes to 0.2.0-SNAPSHOT; the crate manifest goes to 0.2.0, since Cargo has no SNAPSHOT concept and it is what CARGO_PKG_VERSION feeds into Iroh4k.version; and the two smoke assertions that hardcode the string follow. Cargo.lock picked up the crate's own entry on the next build. check-release-version.sh now accepts 0.2.0 and rejects 0.1.0 — verified both directions, since that guard is the only thing standing between a mistyped tag and an artifact that misreports itself. 216 / 216 / 222 green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.1.0 is released, so the working tree should stop building artifacts that carry a version already on Maven Central.
Five places, because the version is genuinely two numbers that have to agree:
build.gradle.ktsdefault →0.2.0-SNAPSHOTiroh4k/src/rust/Cargo.toml[package] version→0.2.0(Cargo has no SNAPSHOT concept, and this is whatCARGO_PKG_VERSIONfeeds intoIroh4k.version)CommonSmokeTestsandDeviceSmokeTestsCargo.lock, updated by the next buildscripts/check-release-version.shnow accepts0.2.0and rejects0.1.0— verified in both directions, since that guard is the only thing standing between a mistyped tag and an artifact that misreports itself.README.mdandSTATUS.mdare deliberately untouched: they describe the latest release, which is still 0.1.0.clippy -D warningsclean;jvmTest216,macosArm64Test216,testAndroidHostTest222, zero failures.