perf: avoid copying DATA payloads in parser - #270
Open
anmonteiro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid allocating a fresh bigstring for every parsed HTTP/2 DATA frame.
Instead of using
Angstrom.take_bigstringfor DATA payloads, carry a(buffer, off, len)payload view throughFrame.Dataand write directly into theBody.Readerbuffer.Why
Angstrom.take_bigstringcopies.On the request/response body hot path, that meant one intermediate bigstring allocation per DATA frame before the body bytes were copied into the reader-side Faraday buffer.
This change removes that intermediate allocation while keeping header-block parsing unchanged.
Validation
dune build --display=short @runtest-test_h2 @runtest-test_h2_client @runtest-test_h2_serverObserved benchmark delta on the local upload benchmark:
4.21s(364.40 MiB/s)3.70s(414.99 MiB/s)