Skip to content

perf: avoid repeated iovec rescans in DATA chunking #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmonteiro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: avoid repeated iovec rescans in DATA chunking #266

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 25 additions & 17 deletions lib/serialize.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,19 +113,6 @@ let write_priority t { Priority.exclusive; stream_dependency; weight } =
* Note: we store priority with values from 1 to 256, so decrement here. *)
write_uint8 t (weight - 1)

let bounded_schedule_iovecs t ~len iovecs =
let rec loop t remaining iovecs =
match remaining, iovecs with
| 0, _ | _, [] -> ()
| remaining, { IOVec.buffer; off; len } :: xs ->
if remaining < len
then schedule_bigstring t ~off ~len:remaining buffer
else (
schedule_bigstring t ~off ~len buffer;
loop t (remaining - len) xs)
in
loop t len iovecs

let bounded_write_iovecs t ~len iovecs =
let rec loop t remaining iovecs =
match remaining, iovecs with
Expand Down Expand Up @@ -588,7 +575,22 @@ module Writer = struct
if not (is_closed t.encoder)
then
let { max_frame_payload; _ } = frame_info in
let rec loop iovecs remaining =
let rec schedule_from_cursor t iovecs head_consumed remaining =
match remaining, iovecs with
| 0, _ -> iovecs, head_consumed
| _, [] -> [], 0
| remaining, { IOVec.buffer; off; len } :: xs ->
let off = off + head_consumed in
let len = len - head_consumed in
if remaining < len
then (
schedule_bigstring t ~off ~len:remaining buffer;
iovecs, head_consumed + remaining)
else (
schedule_bigstring t ~off ~len buffer;
schedule_from_cursor t xs 0 (remaining - len))
in
let rec loop iovecs head_consumed remaining =
if remaining > 0
then (
let chunk_len =
Expand All @@ -606,11 +608,17 @@ module Writer = struct
}
else frame_info
in
let next_iovecs = ref iovecs in
let next_head_consumed = ref head_consumed in
write_frame_with_padding t.encoder frame_info Data chunk_len (fun t ->
bounded_schedule_iovecs t ~len:chunk_len iovecs);
loop (IOVec.shiftv iovecs chunk_len) (remaining - chunk_len))
let iovecs', head_consumed' =
schedule_from_cursor t iovecs head_consumed chunk_len
in
next_iovecs := iovecs';
next_head_consumed := head_consumed');
loop !next_iovecs !next_head_consumed (remaining - chunk_len))
in
loop iovecs len
loop iovecs 0 len

let write_priority t frame_info priority =
if not (is_closed t.encoder)
Expand Down