scheduler: make closed-stream cleanup expiry-driven - #265
Merged
Conversation
anmonteiro
force-pushed
the
fix/closed-stream-cleanup-expiry-queue
branch
from
March 9, 2026 03:31
4ff42b8 to
b939202
Compare
anmonteiro
force-pushed
the
fix/closed-stream-cleanup-expiry-queue
branch
from
March 9, 2026 03:37
b939202 to
8a8eda1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marked_for_removaltable scans with an expiry queue keyed by stream idnext_write_operationpollingDetails
Previously, TTL decrement/removal for closed streams happened inside
Scheduler.flush(write scheduling), so idle/read-mostly connections could retain closed streams indefinitely if writes were not polled.This PR introduces:
cleanup_epoch+cleanup_queueon scheduler rootmark_for_removalenqueuesstream_id -> expires_attick_closed_streamsadvances epoch and pops expired entries onlyValidation
dune runtest --no-bufferpassesclosed stream cleanup does not depend on write polling