Skip to content

[h2] Reqd: explicitly set fixed responses to "Complete" after sending #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anmonteiro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[h2] Reqd: explicitly set fixed responses to "Complete" after sending #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/reqd.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ let flush_response_body (t : t) ~max_bytes =
0)
else (* no pending output but Body is still open *)
0
| Fixed ({ iovec = { buffer; off; len } as iovec; _ } as r)
| Fixed ({ iovec = { buffer; off; len } as iovec; response } as r)
when max_bytes > 0 ->
let is_partial_flush = max_bytes < len in
let frame_info =
Expand All @@ -504,7 +504,10 @@ let flush_response_body (t : t) ~max_bytes =
let len_to_write = if is_partial_flush then max_bytes else len in
write_buffer_data t.writer ~off ~len:len_to_write frame_info buffer;
r.iovec <- Httpaf.IOVec.shift iovec len_to_write;
if not is_partial_flush then close_stream t;
if not is_partial_flush
then (
stream.response_state <- Complete response;
close_stream t);
len_to_write
| Fixed _ | Waiting | Complete _ -> 0)
| _ -> 0
Expand Down