Skip to content

Lwt-unix: Fix file descriptor leak with Lwt_unix.shutdown #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
francoisthire wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Lwt-unix: Fix file descriptor leak with Lwt_unix.shutdown #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lwt-unix/gluten_lwt_unix.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,18 @@ module Io :
match Lwt_unix.state socket with
| Closed -> Lwt.return_unit
| _ ->
Lwt.catch
Lwt.finalize
(fun () ->
Lwt_unix.shutdown socket SHUTDOWN_ALL;
Lwt.catch
(fun () ->
Lwt_unix.shutdown socket SHUTDOWN_ALL;
Lwt.return_unit)
(function
| Unix.Unix_error (Unix.ENOTCONN, _, _) -> Lwt.return_unit
| exn -> Lwt.reraise exn))
(fun () ->
Lwt_unix.close socket)
(fun _exn -> Lwt.return_unit)


let read socket bigstring ~off ~len =
Lwt.catch
Expand Down