Skip to content

Fix NameError in ExportFolder.export progress signal#22

Open
KMneko wants to merge 1 commit into
ankilab:mainfrom
KMneko:fix-exportfolder-progress-signal
Open

Fix NameError in ExportFolder.export progress signal#22
KMneko wants to merge 1 commit into
ankilab:mainfrom
KMneko:fix-exportfolder-progress-signal

Conversation

@KMneko

@KMneko KMneko commented Jul 22, 2026

Copy link
Copy Markdown

In deepd3/core/export.py, ExportFolder.export() iterates over self.rois using for k, v in self.rois.items(), but emits the progress signal using int(z), where z is undefined:

self.zSignal.emit(int(z), len(self.rois.keys()))

This raises NameError: name 'z' is not defined on the first iteration. As a result, "Export ROIs to folder" only writes the first z-plane's ROIs instead of all planes.

This PR replaces z with k:

self.zSignal.emit(int(k), len(self.rois.keys()))

Tested locally (Python 3.9): after the change, "Export ROIs to folder" produces one folder per z-plane for the full stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant