Give the release lane the X11 headers 26.08 made mandatory - #68
Merged
Conversation
The v0.5.0 tag build failed on the Linux cell at configure, in under a second,
while Windows and macOS packaged and uploaded fine:
Could NOT find X11 (missing: X11_X11_INCLUDE_PATH X11_X11_LIB Xt)
MaterialXConfig.cmake:67 (find_dependency)
pxrConfig.cmake:90 (find_dependency)
This is the same defect 0ead959 diagnosed and fixed two commits earlier: 26.08
bundles MaterialX 1.39.5, whose exported config gained an unconditional
`find_dependency(X11 REQUIRED COMPONENTS Xt)` on non-Apple UNIX, and
pxrConfig.cmake find_dependency(MaterialX)s -- so on Linux, X11 dev headers are
a hard requirement of `find_package(pxr)` itself.
That fix went into ost-source-ci.yml and motion-ci.yml. It did not go into
release.yml, and the reason it was missed is the point worth recording:
release.yml is hand-authored, so `ost ci generate` never touches it, and no
pull_request event runs it. The PR lane went green on all twelve cells at the
exact commit the tag points at and proved nothing whatsoever about the release
lane. The gap was invisible until a tag push was the thing that exercised it.
So this does not just add the step. openstrata.ci.yaml's standing-exception note
said the hand-added step lives in one workflow; it lives in three, two of them
hand-authored, and it now says so and says to add it with any new Linux job.
release.yml's header said its runtime pins mirror the CI contract; the mirroring
obligation covers host packages the contract cannot express, and it now says
that too.
Verified with a release.yml workflow_dispatch dry run on this branch -- the same
build/verify/package lanes as a real tag, with no release object created --
because that is the only event that exercises this file.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.5.0タグの build が Linux セルの configure で 1 秒未満で落ちた。Windows と macOS は package / upload まで完走している。これは 2 コミット前の 0ead959 が診断・修正したのと同一の欠陥。26.08 が同梱する MaterialX 1.39.5 のエクスポート済み config に、非 Apple UNIX で無条件の
find_dependency(X11 REQUIRED COMPONENTS Xt)が入り、pxrConfig.cmakeが MaterialX にfind_dependencyするため、Linux では X11 dev ヘッダがfind_package(pxr)自体の hard requirement になっている。なぜ green な PR レーンで捕まらなかったか
0ead959 の修正は
ost-source-ci.ymlとmotion-ci.ymlに入り、release.ymlには入らなかった。見落とした理由がこの PR の要点:release.ymlは手書きなのでost ci generateが触らないpull_requestイベントでは一度も実行されないタグが指すのと同じコミットで PR レーンの 12 セルすべてが green だったが、それは release レーンについて何も証明していなかった。tag push が初めてこのファイルを実行した時点まで、このギャップは不可視だった。
変更内容
release.ymlの build ジョブに apt-get ステップを追加。configure が走る 4 箇所（build / test / package /--from-package）すべてを 1 ステップでカバーするopenstrata.ci.yamlの standing-exception 注記は「手書き追加ステップは 1 つの workflow にある」と書いていた。実際は3 つ（うち 2 つが手書き）なので、その旨と「Linux ジョブを追加したら必ずこのステップも追加する」ことを明記release.ymlのヘッダは runtime pin が CI contract をミラーすると書いていた。ミラー義務は contract が表現できない host package にも及ぶので、それも明記CHANGELOG.mdの[0.5.0]§ Changed に記録。タグに載って出るので、黙って運ばない検証
このブランチで
release.ymlのworkflow_dispatchドライラン（run 30202152151）を実行 — 実タグと同じ build / verify / package レーンで release object は作らない。このファイルを実行する唯一のイベントがこれなので、PR の green ではなくこれが根拠。release-linuxが success。この後
v0.5.0タグ（build が失敗し release object は未作成 = assemble は skip）を、この PR のマージコミットに貼り替える。VERSIONとCHANGELOGの[0.5.0]節は据え置き。🤖 Generated with Claude Code